Party affiliation: Labour Party
Councillor, Edinburgh Corporation, 1970-1975. Councillor, Lothian Region, 1974-1979. Chairman, Education Committee.
Chairman, Education Committee of Convention of Scottish Local Authorities, 1975-1979. Member of Parliament, since 1979. Member, Parliamentary Assembly of Council of Europe and Western European Union, 197981.
Member, House of Commons Foreign Affairs Committee, 1981-1984. Opposition Spokesman on European Affairs, 1984-1985. Opposition Spokesman on Foreign Affairs, 1985-1992.
Opposition Spokesman on Defence, since 1992. President, Scottish Union of Students, 1965-1967. Manager, Fund for International Student Co-operation.
1967-1968; Scottish Organiser, European Movement, 1968-1969. Director, Enterprise Youth, 1969-1973. Director, Age Concern Scotland, 1973-1979.