Career
He wrote poetry in both Scots and Scottish English and well as plays, literary reviews and critical studies of literature. He was latterly a tutor and reader of Scottish literature at the University of Glasgow, where he was instrumental in the struggle to create the first Department of Scottish Literature to exist in Scotland, established in the academic year 1971-1972.