Career
He spent most of his career playing for Shelbourne in the League of Ireland with whom he had three spells from 1958 to 1966, 1971-1975 and 1978-1980, managing them during the 1979-1980 season. Professional During his time with Shels, Barber scored a club record 126 league goals. His goal in the 1960 final was a lob from almost forty yards.
In March 1966, Barber signed for Birmingham City, but never became a regular.
At the end of the 1966-1967 season he was offered a chance to sign for Chicago Spurs in the National Professional Soccer League. After just two days in America, Barber scored twice on his debut at Oakland Clippers, and went on to finish third top scorer in the NPSL. At the end of the season the franchise moved and became Kansas City Spurs and Barber moved with them and finished second top scorer in the league that season.
He made two appearances in Europe and went on to be the club"s top goalscorer that season. Then Barber got the offer of moving to Vienna to play for Wiener Sport-Club, but despite an impressive start with nearly a goal a game in his first eleven games, an injury and subsequent row about the treatment for it saw him eventually return to Dublin as Shels paid an International Rectifier £3,000 transfer fee for him in November 1971.
He played for Shels in their FAI Cup Final defeats in 1973 and 1975, being red-carded in the replay of the 1973 decider in Flower Lodge.
Barber was Shels top league scorer at the end of ten different seasons. At the end of the 2012 League of Ireland season Barber is twelfth in the all-time League of Ireland goalscoring list with 141 league goals National team Barber was capped twice by the Republic of Ireland national football team during his time with Shels in a World Cup qualifier in Spain and a friendly against Belgium. He was Rovers" assistant manager in the 1978-1979 season.
He managed Shels the following season.