He made over 430 appearances in the Football League, most notably for Brentford, Halifax Town, Ashington and Barrow. Early years A right winger, Foster began his career with hometown Division One club Sunderland. He later dropped through the leagues and had spells with Division Three North sides Ashington, Halifax Town and, winning the league title with the latter club in the 1925/26 season.
Foster transferred to Division Three South side in 1926, winning the league title in his first season with the Robins.
After two seasons in Division Two, Foster departed Ashton Gate in 1929. Brentford Foster and teammate Cyril Blakemore joined Division Three South side Brentford in the summer of 1929, for a combined fee of £500.
He was a virtual ever-present until the 1932/33 season, when he made just 22 appearances, but still contributed to the Bees" Division Three South title. Foster departed Griffin Park in 1933, having made 153 appearances and scored 21 goals for the club
Later career Foster signed for Division Three North side Barrow in the summer of 1933, scoring 16 goals during the 1933/34 season.
He later moved to Birmingham & District League side Colwyn Bay United. After retiring from football, Foster had a spell coaching in Belgium. Brentford Football League Division Three South (1): 1932/33.