Career
He made his debut for Sunderland on 13 September 1890 against Burnley, Sunderland lost the game 3–2. Millar played for Sunderland under two different spells. In 1890-1896 and 1900-1904 respectively.
Overall, at his time at Sunderland, he made 260 appearances, scoring 122 goals.
His two spells at Sunderland were separated with a stay at Rangers. He represented the Scottish League XI three times during his time with Rangers.
At the time of his death he was the trainer for Chelsea.