Career
During his time at Rangers he scored 249 goals in 259 games. Smith moved from East Stirlingshire to Rangers in 1928 and made his debut against Hamilton Academical in March 1929. After Rangers missed out on their sixth successive League championship in season 1931-1932, during which Smith had scored 5 goals in 8 games, the championship returned to Ibrox the following season and Smith finished top scorer with 34 goals, including 4 hat-tricks.
In season 1933-1934, Smith and striking partner Bob McPhail, notched up 72 goals between them in 47 games as Rangers continued their dominance of Scottish football.
Smith also collected his first Scottish Cup medal, scoring in a 5-0 defeat of Street Mirren in the final at Hampden. Success for Smith and Rangers continued.
He also collected his second Scottish Cup medal, scoring twice in the 2-1 against Hamilton Academical in the final. Smith continued to play for Rangers during the unofficial matches played during the War but retired from football upon the return of official domestic football in 1946-1947.
After he retired he continued as a club trainer then chief scout until 1967.