Career
He played for FV 1912 Wiesental, Karlsruher Football Club Phönix (1936–1940), Eintracht Frankfurt (1939-1940), Civil Service Commission 03 Kassel (01/40–1941), Blau Weiß 90 Berlin (01/42–10/42), FV Saarbrücken (01/43–06/43), 1. Football Club Nuremberg (07/43–1945), Football Club Bayern Munich (1945-1946), FV Saarbrücken (1946), Karlsruher FV (1946–1947), VfB Stuttgart (1947–1949) and Stuttgarter Kickers (1948–1953). After he ended his career, he went on to become a coach.
He coached New York Hakoah in the American Soccer League (the team also competed in the International Soccer League).
He also trained South Carolina Geislingen/Steige (Germany, 1954), 1st German Sport Club Brooklyn (1956–1964), the Junior All-Stars New York (1960), and the team of the German-American Soccer association. During his time in the United States. he has been called "John" instead of "Johann".
Herberger coached the United States men"s national soccer team for one game in 1964.