He played as a centre back. He is currently the first team manager at Southern League side Cinderford Town. Brough spent seven years with Cheltenham after joining from Hereford United at the start of season 1998-1999, at the same time as Neil Grayson and David Norton.
Brough made 208 appearances for Cheltenham in those seven years, scoring 14 goals.
A strong centre back, John often found himself deployed as a successful makeshift centre forward. Brough scored the first and played a part in the second of 2 injury time goals that gave Cheltenham a 2-1 away victory over League rivals Rushden and Diamonds in the 98-99 season which saw promotion to the Football League.
He joined Newport County from Aldershot Town in March 2006 and was released by Newport at the end of the 2006-2007 season. He went on become Head of Youth for Cheltenham Town.
In May 2013, he was appointed first team manager at Southern League side Bishop"s Cleeve, replacing former boss Alex Sykes.
Having served less than a season as manager at Bishop"s Cleeve, he left the club to become manager at league rivals Cinderford Town in April 2014.