After graduating from Yale in 1957, Miller was commissioned in the Marine Corps. He was an infantry officer, commanded a United States Marine battalion, and served as an advisor to the Republic of Vietnam Marine Corps during the Vietnam War. Later in his career, he was Deputy Director of the Marine Corps" History and Museums Division and was a speechwriter to three Commandant of the Marine Corps.
He joined the United States Naval Institute staff on 19 September 1985 and served until 31 August 2000, becoming managing editor of Proceedings and Naval History Magazine, the latter of which he had helped to establish in 1988.
Military decorations Other awards.