He was educated at the grammar school in Bala where his contemporaries included Robert Thomas Jenkins. He then studied classics followed by theology at Jesus College, Oxford.
Whilst in Cardiff, he was heavily involved in fundraising for the church, and eventually resigned in 1938 to become the full-time secretary of the Sustentation Fund for South Wales, later of the Fund for the whole denomination, in which capacity he ensured that the church and its ministers were on a firmer financial basis than before. He also campaigned at a national level on behalf of the people of south Wales, leading a group to London in 1932 to see the Prime Minister Stanley Baldwin about the poverty of the valleys. He was awarded an honorary doctorate of divinity by the University of Wales in 1954.
He died in Cardiff on 29 July 1959.