Career
Weir signed for Hibernian in 1942, but did not play league football until the 1946-1947 season due to the Second World War. During the war, Weir made guest appearances for Cardiff City and Brighton. Weir had scored 14 goals in 19 league matches (and four goals in his only Scottish Cup appearance for Hibs) by the end of January 1947, but was allowed to join Blackburn for a fee of £10,000.
This was perhaps because Hibs had the services of most of the Famous Five, which allowed the club to sell other talented players, including Weir, Leslie Johnston and Alex Linwood.
Weir was not such a great success with Blackburn, however, and was allowed to return to Scotland in 1948, signing for Celtic for a fee of £7,000. This transfer signalled a change of attitude by Celtic, who "had treated wartime football with contempt" and had passed up the opportunity to field guest players of international standing, including Matt Busby.
Weir"s arrival did not immediately arrest Celtic"s decline, and the club entered the final day of the 1947-1948 season with an outside chance of being relegated. Weir then went on to score two goals in the Glasgow Cup final against Third Lanark that year.
Normally that trophy would have been held in low esteem, but a crowd of 87,000 attended, realising the potential of the Celtic support.
Bob Crampsey wrote that Weir was an "unlucky" player, as he missed out on the positive effect that Jock Stein was to have on Celtic. Coincidentally, Weir later had a brief spell with Llanelli A.F.C., the Welsh club that Stein played foreign Despite making 100 appearances for Celtic, Weir did not earn international honours due to stiff competition from several players, including Lawrie Reilly.