He is mainly remembered for his time with Celtic F.C. He had a relatively short period as their northern 1 goalkeeper, in between Charlie Shaw and John Thomson.
He did take part in winning the League and the Cup once each. He later played for South Shields F.C., Hamilton Academical F.C. and Albion Rovers F.C.