Campbell joined Rangers in January 1906 from Celtic, having only moved from Queen"s Park in June 1905 and helped ease the injury crisis at Ibrox. He was a right back but in later years would convert to a striker. He made his Rangers debut against Portuguese Glasgow on 20 January 1906.
In the 1906-1907 season Campbell saw himself being played up front.
He finished the following two seasons as Rangers top scorer with 25 and 17 goals respectively but he switched back to defence with the arrival of Willie Reid. During his Rangers career he made 211 appearances and scored 56 goals.
After his retirement he became a director of Rangers in 1926.