He served in the Mexican–American War. During the Civil War, he led the 68th Pennsylvania Volunteer Infantry for nine months in 1863 and 1864 while Colonel Andrew H. Tippen was captured. He served at the Battle of Gettysburg as a major and in the Wilderness Campaign as a lieutenant colonel.
He received his appointment as brevet brigadier general dated to March 13, 1865.
Upon his death in 1893, he was buried in Section 116, Lot 227 of Mount Moriah Cemetery in Yeadon, Pennsylvania.