Career
Larne
Born in Belfast, Weir started his career with the Larne youth system. He started playing for the first team in the 2004-2005 season as a 15-year-old and he scored his first goal in a 5–2 victory over Crusaders on 9 October 2004. He had unsuccessful trials with Fulham, Stoke City and Rangers, although Larne manager Jimmy McGeough criticised these, saying "I"m not sure it proves anything.
He"s a great prospect and one who"ll learn his trade in senior football here".
Weir agreed to sign for English Championship club Sunderland in February 2005. Sunderland
Weir played for Sunderland in their youth team and was part of the team that reached the Premier Academy League Final in May 2007, where they were beaten 4–1 by Leicester City in a penalty shoot-out.
He joined Conference Premier side York City on a one-month loan on 12 November 2010 following a trial. He made his debut in a 1–1 draw with Wrexham on 14 November 2010 and after impressing manager Gary Mills the loan was extended until 10 January 2011 in December.
He finished the loan with eight appearances.
Tranmere Rovers
Weir signed for League One club Tranmere Rovers on loan until the end of the 2010-2011 season on 14 February 2011. He made his debut in a 2–1 defeat at Peterborough United as a 74th minute substitute on 19 February. On 7 April Sunderland announced that he was amongst eight players to be released at the end of the season.
At the end of the 2010-2011 season he was offered a contract by Tranmere and he subsequently agreed to sign for the club permanently.
He signed for the club on a one-year contract on 29 June 2011. He was released at the end of the 2011-2012 season.
Burton Albion
On 31 May 2012, Weir signed a two-year contract with League Two club Burton Albion. Weir was part of the Northern Ireland under-18 squad in March 2005 and was capped by the team during a week-long visit to the Canary Islands in February 2006.
He was named captain of the under-19 squad in October and led the team out in a 4–2 defeat to Belgium, and in July 2007 was called up for the 2007 Milk Cup and he started as the team were beaten 4–1 by Israel in August.
He was named in the under-21 squad in February 2008 to play Israel as a replacement for Dermot McCaffrey. Weir was capped once by the Northern Ireland B team in 2009. He played for the under-21s in a 1–1 draw with Germany in October 2009.