Career
After early service in the Royal Engineers he became a staff officer prior to the outbreak of the First World War. His main role in the war was as Director of Military Intelligence at the War Office in 1916-1918. Macdonough joined the Royal Engineers in 1884.
He became Deputy Assistant Adjutant General, Royal Engineers at Headquarters Ireland in 1898, Brigade Major at the School of Military Engineering in 1899 and Deputy Assistant Quartermaster General for Thames District in 1903.
He went on to be a General Staff Officer at the War Office in 1906. He served in World War I as a General Staff Officer at General Headquarters of the British Expeditionary Force and then as Director of Military Intelligence at the War Office from 1916.
In 1918 he became Adjutant-General to the Forces, a post he held until September 1922.