Background
The son of George Moir, a vintner running "The Old Ship Inn", he was born in Aberdeen, and educated there.
The son of George Moir, a vintner running "The Old Ship Inn", he was born in Aberdeen, and educated there.
Moving to Edinburgh, he entered a lawyer"s office. They met in the Advocates" Library, and formed a lifelong friendship. On 2 July 1825 Moir was admitted advocate.
In the 1830s he is listed as living at 63 Northumberland Street in Edinburgh"s Second New Town.
From 1835 to 1840 Moir was Professor of Rhetoric and Belles Lettres in the University of Edinburgh, appointed on the occasion when Carlyle was unsuccessful. He continued in practice at the Scottish bar, and in 1855 was appointed sheriff of Ross and Cromarty, a post which in 1859 he exchanged for the shrievalty of Stirlingshire.
In 1864 the Faculty of Advocates chose Moir as professor of Scots law at Edinburgh, but, in bad health, he resigned in less than a year. Moir gave up his shrievalty in 1868, and died at his house in Charlotte Square, Edinburgh, on 19 October 1870.